Allow to use file descriptors with virtio-serial and virtio-net #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should allow for more efficient user-space networking, it's no more needed to create a tap interface in the guest and forward the network traffic over virtio-vsock. This adds a 'fd' parameter to '--device virtio-net' which expects a file descriptor number. It must correspond to a connected datagram socket.
This allows to redirect the VM network traffic to a different process from the command line: term1> nc --listen --unix /tmp/unix.sock term2> vfkit --device virtio-net unixSocketPath=/tmp/unix.sock This complements the '--device virtio-net fd=x' support which was added in the previous commit, it might be easier to directly specify a Unix socket to use.
This makes it possible to have an interactive serial console.
This returns a standard golang exec.Command, and takes care of setting ExtraFiles as needed, ... Longer term we can add more APIs to start the vfkit process, monitor it, ...
anjannath
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing a file descriptor to virtio-serial allows to implement an interactive console.
Passing a file descriptor to virtio-net makes it possible to forward the network traffic from guest network interface to a host socket without going copying the data through virtio-vsock or such.